cleye icon indicating copy to clipboard operation
cleye copied to clipboard

fix: add export for flag types

Open transitive-bullshit opened this issue 10 months ago • 2 comments

Fixes #27

Unrelated question; do you use prettier? It surprised me when I went to contribute and my save by default made unrelated formatting changes w/ prettier defaults. I inferred what I think is close to your prettier config, but without a repo-specific prettier file, it makes it more difficult for folks to contribute. I'm sure you have a reason for doing things w/ your repos the way you do; I just want to understand :)

{
	"singleQuote": true,
	"trailingComma": "all",
	"useTabs": true
}

Thanks!

transitive-bullshit avatar Mar 31 '24 19:03 transitive-bullshit

hmmm the CI error appears unrelated to this PR. I could push a fix but would rather keep the PR simple & focused on one thing.

transitive-bullshit avatar Apr 01 '24 09:04 transitive-bullshit

No worries. The CI error is expected—it fails because it's a fork.

I'm using ESLint instead of Prettier. Stylistically, your changes look fine.

Just to double check, how are you planning to use Flags?

I think it's only used by cleye to enforce a base shape to the input flags (e.g. xyz extends Flags), so it should only be used in user-code like so: const sharedFlags = { ... } satisfies Flags.

But if that's the use-case, I'm wondering if const sharedFlags = { ... } as const would also suffice.

privatenumber avatar Apr 01 '24 09:04 privatenumber

Closing due to lack of response. Happy to re-open when there's a response.

privatenumber avatar Jun 20 '24 05:06 privatenumber