html-to-docx icon indicating copy to clipboard operation
html-to-docx copied to clipboard

Add pageSize as an optional additional document option

Open juralio-james opened this issue 3 years ago • 3 comments

Enhancement to allow the user to add a custom pageSize parameter to generate non U.S. letter size documents. Based off of #60 but without the breaking change, as the existing default height and width options are applied if no pageSize options are supplied

juralio-james avatar Apr 12 '22 13:04 juralio-james

@juralio-james Sorry for seeing this so late, but could you please set it to target develop instead of master?

privateOmega avatar Jun 01 '22 07:06 privateOmega

@privateOmega no problem, that should be it updated now

juralio-james avatar Jun 01 '22 07:06 juralio-james

@juralio-james My bad, I should have mentioned that you should have cherry-picked your commits and applied it on top of a branch from develop, or just rebase it by changing the base, something like this.

Current state of this would mess up the develop branch and other PRs made to it.

privateOmega avatar Jun 01 '22 08:06 privateOmega

cleaned it up and merge it as https://github.com/privateOmega/html-to-docx/pull/161

privateOmega avatar Nov 09 '22 18:11 privateOmega

@juralio-james Thanks for this changeset and I apologize for the delay.

privateOmega avatar Nov 09 '22 18:11 privateOmega

@privateOmega Thank you for cleaning it up! Totally fell off my radar

juralio-james avatar Nov 10 '22 08:11 juralio-james