privacyguides.org icon indicating copy to clipboard operation
privacyguides.org copied to clipboard
verified publisher icon privacyguides

update!: Add LTeX for VS Code and remove LanguageTool

Open jonaharagon opened this issue 7 months ago • 6 comments

List of changes proposed in this PR:

  • Remove LanguageTool: FORUM-26683

  • Add LTeX for VSCode

    • This is a LanguageTool-based extension that defaults to downloading and running a fully self-hosted version of LanguageTool completely offline. It is also the only fully self-hosted install of LanguageTool that I have personally tested, and we use it already in our default VSCode config: https://github.com/privacyguides/privacyguides.org/blob/b2251c7b67aaa8369a82c341f9cfdbfd04a7f3da/.vscode/extensions.json#L30

    • I'm not suggesting this is a full LanguageTool replacement in itself, but I am suggesting that we add more recommendations similar to this one (ones that bundle LanguageTool self-hosted) in future PRs, instead of blanket recommending LanguageTool itself, due to concerns with the cloud version of LT. So this PR is just a starting point.

jonaharagon avatar May 07 '25 03:05 jonaharagon

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/remove-languagetool-other-than-self-hosting/26683/8

privacyguides-bot avatar May 07 '25 03:05 privacyguides-bot

Your preview is ready!

Name Link
Latest commit e041559a64e2699d50223a307d8b04c4c3b170a7
Preview https://pr3031.unreviewed.privacyguides.dev/en/

github-actions[bot] avatar May 07 '25 03:05 github-actions[bot]

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/ltex-spelling-grammar-check/27547/1

privacyguides-bot avatar May 13 '25 13:05 privacyguides-bot

Maybe we should also split the PRs between adding LTeX and removing LanguageTool, no reason for one to hold up the other.

friadev avatar May 13 '25 18:05 friadev

I don't think this will really hold anything up, since it is the same tool simply packaged differently.

jonaharagon avatar May 13 '25 18:05 jonaharagon

I’m just not really understanding why we are adding LTeX in the same PR, they should be separate, especially since it’s not approved on the forum and several team members are against it. Bundling uncontroversial changes with ones that haven’t been properly discussed yet causes important changes to get delayed for months.

friadev avatar Nov 06 '25 16:11 friadev