privacyguides.org icon indicating copy to clipboard operation
privacyguides.org copied to clipboard

Update Qubes doc

Open nopeitsnothing opened this issue 3 years ago • 7 comments
trafficstars

adding better documentation to Qubes OS page

Affected link: https://www.privacyguides.org/qubes/

  • [x] add source code (GitHub) link
  • [x] add some more description to Knowledge Base:
    • https://privacyguides-privacyguides-org-preview-pr-1568.surge.sh/basics/qubes-overview/
  • [x] further explain Xen hypervisor
  • [x] some description of the goal of Qubes OS
  • [x] explain how Qubes (formerly appVMs) work
  • [x] explain compartmentalization in Qubes OS/across appVMs
  • [x] explain color coding etc.

Resolves: #1465 - comment concerns and questions there to avoid cruft here

nopeitsnothing avatar Jul 21 '22 14:07 nopeitsnothing

🎊 PR Preview 6e144e23e77fad81555c5bd1430b44dd9237070b has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1568.surge.sh

:clock1: Build time: 77.974s

🤖 By surge-preview

github-actions[bot] avatar Jul 21 '22 14:07 github-actions[bot]

You should stick with the buttons at the bottom

d4rklynk avatar Jul 21 '22 17:07 d4rklynk

I think a schema would be appropriate for qubesos

d4rklynk avatar Jul 22 '22 05:07 d4rklynk

I think this LGTM at a glance, but I do want to go through this later tonight and update some of the wording to make it more stylistically similar to the rest of the website (we shouldn't use words like 'users,' etc. I'm not sure if we have style guidelines actually published anywhere). Also, if this is complete could you update the checklist on the original issue? :)

jonaharagon avatar Aug 17 '22 21:08 jonaharagon

Updated Issue #1465 and committed review edits. Thanks Jonah!

nopeitsnothing avatar Aug 19 '22 09:08 nopeitsnothing

Moved some things around. I think we could have a better summary of Qubes for beginners than this offers, but this LGTM for now and we can tackle rewording the initial overview in a future PR.

Works for me. I was pretty sure the final commits would be for organization anyways, feel free to send it.

nopeitsnothing avatar Aug 23 '22 19:08 nopeitsnothing

The writing style here feels off compared to the rest of the website. I wouldn't merge this PR as-is. This is very much an "intro to Qubes" addition, which we do need as we currently don't say anything on the OS, but I do want us to eventually add more advanced sections that dive deeper into what Qubes can achieve.

Furthermore, just to be on the safe side, can someone confirm that we are allowed to use the graphic from the Qubes OS website? (https://privacyguides-privacyguides-org-preview-pr-1568.surge.sh/assets/img/qubes/structure.png)

matchboxbananasynergy avatar Aug 28 '22 09:08 matchboxbananasynergy

Icons all-the-sudden don't work for the sidebar?

nopeitsnothing avatar Oct 25 '22 01:10 nopeitsnothing

~~Gonna take a look...~~ Fixed

In the future, please consider rebasing your commits on top of main instead of doing a standard merge of main into your own branch: https://github.com/privacyguides/privacyguides.org/wiki/Git-Recommendations#rebase-on-git-pull

jonaharagon avatar Oct 25 '22 02:10 jonaharagon

Deploy Preview for privacyguides ready!

Name Link
Latest commit b5b50b78be62d2a4af0883877bac19c04af8544d
Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/63575270fe99550008adfb63
Deploy Preview https://deploy-preview-1568--privacyguides.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 25 '22 03:10 netlify[bot]

Deploy Preview for privacyguides ready!

Name Link
Latest commit e3ee1cf1bba44392c5a6b7cb399cab78aac99f57
Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/638473517294bf0008e8b114
Deploy Preview https://deploy-preview-1568--privacyguides.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 25 '22 03:10 netlify[bot]

@jonaharagon

Make sure the changes I made in https://github.com/privacyguides/privacyguides.org/commit/7a3f70459ed644e6817d3fe9ac97bb25da88b986 make sense. I think the standalone Qubes page doesn't make sense in our recommendations section, so I've combined the Linux and Qubes pages into a single "Desktop/PC" recommendation page.

Not sure if this makes a lot of sense. It says "Desktop/PC" but has Tux as the icon, and the page starts talking about Linux distributions right away and then lists Qubes, which isn't really a Linux distribution. I'm not 100% opposed to combining the two pages or have a general desktop OS page, but it would need a serious refactoring of the Linux page which I think is out of scope for this PR.

I would leave the Qubes page in Recommendations as it was for now so that we can add the additional information about Qubes, and then decide whether we want to reorganize the content.

matchboxbananasynergy avatar Oct 27 '22 06:10 matchboxbananasynergy

I propose moving Qubes OS to a new section like Security Focused Distributions. There's an anonymity focused section already:

Qubes-OS

nopeitsnothing avatar Oct 28 '22 17:10 nopeitsnothing

It says "Desktop/PC" but has Tux as the icon, and the page

Ask @jonaharagon. I did not change the icons for this page.

BUT, I can say it makes sense having this title, since you only recommend Linux Desktop OS on the website, and those are all Linux distributions suited for use on desktop which are listed in the cards.

nopeitsnothing avatar Oct 30 '22 16:10 nopeitsnothing

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v2-29/10471/1

privacyguides-bot avatar Nov 28 '22 10:11 privacyguides-bot