gpc-optmeowt icon indicating copy to clipboard operation
gpc-optmeowt copied to clipboard

Fix analysis mode UI

Open SebastianZimmeck opened this issue 2 years ago • 5 comments

It seems to me there is something wrong with the green checkmarks and/or the Privacy String displayed in the popup.

Here is an analysis where the site respects GPC: the checkmark in the fourth line is green and the third position character in that line is Y.

Screen Shot 2022-08-03 at 4 34 21 PM

Here is an analysis where the site does not respect GPC: the checkmark in the fourth line is red and the third position character in that line is N.

Screen Shot 2022-08-03 at 4 35 51 PM

Now here is the problem. Here is an analysis where the site does respect GPC or not? The checkmark in the fourth line is green and the third position character in that line is N.

Screen Shot 2022-08-03 at 4 22 12 PM

I believe the issue is with the string and the checkmark seems to right. Either way, this combination of N and green does not go together.

SebastianZimmeck avatar Aug 03 '22 20:08 SebastianZimmeck

I tried to replicate this problem on my end. For me, I have a combination of N and red, but the ground truth is 1YYY. Screen Shot 2022-08-03 at 18 20 52

Jocelyn0830 avatar Aug 03 '22 22:08 Jocelyn0830

Now here is the problem. Here is an analysis where the site does respect GPC or not? The checkmark in the fourth line is green and the third position character in that line is N.

Screen Shot 2022-08-03 at 4 22 12 PM

I believe the issue is with the string and the checkmark seems to right. Either way, this combination of N and green does not go together.

I tested the analysis mode on https://www.freep.com/ for a couple of times. I was not able to reproduce the result @SebastianZimmeck got. In addition to my last comment, I also got something like Screen Shot 2022-08-03 at 21 44 57

I read through the code and I didn't find any logical errors, but I may need to look more into that as well. My guess now is that the site messes up the privacy string. I am also wondering if there are any other sites that show the same problem.

Jocelyn0830 avatar Aug 04 '22 01:08 Jocelyn0830

OK, so here is what I do in detail:

  1. Clear all browser data and history
Screen Shot 2022-08-03 at 11 52 37 PM Screen Shot 2022-08-03 at 11 53 21 PM
  1. Enable OptMeowt (no other add-ons active)
  2. Visit freep.com
  3. Bring up the browser developer tools
Screen Shot 2022-08-03 at 11 54 54 PM
  1. Do an analysis in analysis mode. I stop it after about 20 seconds when there is 3 or 4 seconds nothing new loaded. So far so good. I get 1YNY.
  2. Now, I do another analysis just as in the previous step, and I get:
Screen Shot 2022-08-03 at 11 58 29 PM
  1. Running __uspapi('getUSPData', 1, (data) => console.log(data)) in the console shows 1YYY. So, yes, they are a little bit slow, possibly because there is so much loaded on the site, but ultimately, the site seems to do the right thing.

Maybe, we still have the old result string stored somewhere.

SebastianZimmeck avatar Aug 04 '22 04:08 SebastianZimmeck

When I disable and re-enable OptMeowt and then run a third analysis, the analysis string is correct 1YYY with green checkmark.

Screen Shot 2022-08-04 at 12 07 46 AM

SebastianZimmeck avatar Aug 04 '22 04:08 SebastianZimmeck

Essentially, this is a problem of updating the analysis results in the popup when an analysis is run multiple times. It is OK to overwrite the previous results. However it appears that currently the checkmark is updated while the string is not. The behavior should be consistent and the string should be updated as well.

Also, what is the situation in the analysis list? Do we also have the same issue as in the popup? If yes, it should be fixed there as well. And there should be consistency between what is displayed in the popup and the analysis list.

This is a fairly minor issue and not worth it to spend a lot of time on. If it is too tricky to resolve, add an entry to the Wiki as a known issue.

SebastianZimmeck avatar Aug 06 '22 23:08 SebastianZimmeck

Also, what is the situation in the analysis list? Do we also have the same issue as in the popup? If yes, it should be fixed there as well. And there should be consistency between what is displayed in the popup and the analysis list.

The situation in the analysis list as well as the exported csv data is the same as in the popup.

The way I resolved this issue is to overwrite the previous result, which seems to work well.

Jocelyn0830 avatar Sep 04 '22 15:09 Jocelyn0830

This should be fixed now.

Jocelyn0830 avatar Sep 04 '22 18:09 Jocelyn0830