zkevm-specs icon indicating copy to clipboard operation
zkevm-specs copied to clipboard

MPT: Review Spec

Open andyguzmaneth opened this issue 3 years ago • 11 comments

  • Requisite: the scope is review and completed by the team #268
  • Get PR ready to review #136 and then review the PR

andyguzmaneth avatar Sep 28 '22 12:09 andyguzmaneth

MPT docs are now cleaned, I think the PR can be reviewed now.

miha-stopar avatar Oct 17 '22 14:10 miha-stopar

@miha-stopar to send the PR when possible

andyguzmaneth avatar Oct 27 '22 13:10 andyguzmaneth

Could be reviewed now:

  • onExistingStorage proof docs were added
  • matching with the scoping document added

miha-stopar avatar Oct 28 '22 15:10 miha-stopar

Next steps: Ready to be reviewed by us first and then ask someone from Taiko.

Estimating this as a 20 and timeboxing it to 2 weeks, leverage the tests. After the 2 weeks reconvene and decide if it requires further review.

andyguzmaneth avatar Nov 10 '22 12:11 andyguzmaneth

@Brechtpd we have this task on our backlog to review MPT Specs. By any chance are you interested in taking this one?

andyguzmaneth avatar Nov 17 '22 13:11 andyguzmaneth

Sure thing, can start working on this next week.

Brechtpd avatar Nov 17 '22 15:11 Brechtpd

Sure thing, can start working on this next week.

@Brechtpd if it helps we can have a call before you begin, maybe just to go briefly over the content.

And thanks for taking this!

miha-stopar avatar Nov 17 '22 15:11 miha-stopar

Yes, thank you so much! @Brechtpd also helps with alignment on overall approach

andyguzmaneth avatar Nov 17 '22 17:11 andyguzmaneth

Will be updated once the witness generator work is finished.

ChihChengLiang avatar May 18 '23 08:05 ChihChengLiang

The spec needs to be rewritten according to the refactor work done on the circuit implementation. Miha will work on it after the witness generator work is finished.

ed255 avatar Jun 01 '23 09:06 ed255

The spec needs to be updated to reflect the changes in the refactor.

ChihChengLiang avatar Aug 16 '23 09:08 ChihChengLiang