zkevm-specs icon indicating copy to clipboard operation
zkevm-specs copied to clipboard

add markdown spec for `begin_tx` & `end_tx` gadgets

Open DreamWuGit opened this issue 3 years ago • 3 comments

currently there is only python implementation for begin_tx & end_tx gadgets, I think it is better to add markdown spec as well like other auxiliary gadgets(CopyToMemory, CopyToLog etc.) , which is useful for better understanding and reading !

Glad to know your opinions!

DreamWuGit avatar Apr 13 '22 01:04 DreamWuGit

You can add end_block to the list :P

ed255 avatar Aug 06 '22 09:08 ed255

Adding markdown spec for begin_tx, end_tx, CopyToMemory, CopyToLog, and end_block sounds like a good idea to me!

ChihChengLiang avatar Aug 08 '22 07:08 ChihChengLiang

Note that CopyToMemory and CopyToMemory execution state no longer exits (the became obsolete with the copy circuit).

ed255 avatar Aug 17 '22 07:08 ed255

I added some comments/questions on the PR directly

rrtoledo avatar Feb 21 '24 19:02 rrtoledo