zkevm-specs icon indicating copy to clipboard operation
zkevm-specs copied to clipboard

Spec out Keccak permutation

Open ChihChengLiang opened this issue 3 years ago • 4 comments

We should add the spec of the keccak circuit here so that it can be audited and reviewed.

Created this issue for the permutation part

ChihChengLiang avatar Mar 11 '22 05:03 ChihChengLiang

Existing one here https://hackmd.io/sK7v0lr8Txi1bgION1rRpw. Now we learned so much, many can be written in a better way.

ChihChengLiang avatar Mar 11 '22 06:03 ChihChengLiang

Isn't permutation already done @ChihChengLiang .

Padding is not the focus together with arbitrary-lenght inputs and I belive there's another issue for it.

Closing this maybe?

CPerezz avatar Apr 08 '22 09:04 CPerezz

The padding part is here https://github.com/appliedzkp/zkevm-specs/issues/143. The permutation is implemented but I'm thinking to move the hackmd spec back to this repo. What do you think?

ChihChengLiang avatar Apr 08 '22 14:04 ChihChengLiang

Sorry @ChihChengLiang I oversaw this.

Whatever you prefer. LGTM to move it. We could also add the diagrams made for the ZKEVM day at Devconnect to make the circuit a bit more visual.

CPerezz avatar May 02 '22 14:05 CPerezz