zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Required opcodes for basic L2 Bridge

Open pinkiebell opened this issue 2 years ago • 2 comments

required environmental opcodes for L2 Bridge
  • [x] CALLVALUE https://github.com/appliedzkp/zkevm-circuits/pull/287
  • [x] CALLDATASIZE https://github.com/appliedzkp/zkevm-circuits/pull/329
  • [x] CALLDATALOAD https://github.com/appliedzkp/zkevm-circuits/pull/346
  • [x] CALLDATACOPY https://github.com/appliedzkp/zkevm-circuits/pull/393
  • [x] ORIGIN https://github.com/appliedzkp/zkevm-circuits/pull/360
  • [x] CALLER https://github.com/appliedzkp/zkevm-circuits/pull/287
  • [ ] BALANCE https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/683
  • [x] CALL https://github.com/appliedzkp/zkevm-circuits/pull/278
  • [x] RETURNDATASIZE https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/703
  • [x] RETURNDATACOPY https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/779
  • [x] LOG1 https://github.com/appliedzkp/zkevm-circuits/pull/335
  • [x] ISZERO #372

#277


A basic native deposit (L1 > L2) test in zkevm-chain given commit 223b38c79bc3c615293bfe2cb7d482cf399500a7.

bus_mapping::evm::opcodes
  • [x] Using dummy gen_associated_ops for opcode LOG1
  • [x] Using dummy gen_associated_ops for opcode SHA3
  • [x] Call to account with empty code is left unimplemented
evm_circuit/witness unimplemented opcodes
  • [x] SHR
  • [x] SHL (https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/578)
  • [x] NOT (https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/565)
  • [x] SHA3
zkevm_circuits::evm_circuit::execution::dummy
  • ExecutionState::SHA3 is implemented with DummyGadget

pinkiebell avatar Mar 04 '22 12:03 pinkiebell

What does the L2 Bridge mean here ? the L2 watcher to L1? @pinkiebell

DreamWuGit avatar Mar 07 '22 02:03 DreamWuGit

L2 bridge means the contract on l2 that allows for deposits and withdraws from L1. So these opcodes need to be supported by zkevm.

barryWhiteHat avatar Mar 07 '22 10:03 barryWhiteHat