zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Published 20 hours ago • verified publisher icon privacy-scaling-explorations

Use logging instead of raw printing for prover workspace member reports

Open CPerezz opened this issue 3 years ago • 4 comments

Currently, we are just printing the info of the CLI bin with println!.

But @ed255 introduced some time ago logging into the workspace. So it would be nice to use it also in the prover workspace member.

This can be taken as implementation example: https://github.com/appliedzkp/zkevm-circuits/blob/28b1ea7a6d3e70fa7b20f47fe24b850c7a48d8b3/integration-tests/src/bin/gen_blockchain_data.rs#L87

CPerezz avatar Feb 22 '22 11:02 CPerezz

I second that. Because it will be great for logs capture&monitoring&analytics.

0xmountaintop avatar Mar 21 '22 00:03 0xmountaintop

Hi, @CPerezz @ed255 , I can do this.

SuccinctPaul avatar Nov 22 '22 02:11 SuccinctPaul

Hi, @CPerezz @ed255 , I can do this.

Hey!!! That's nice!! Ping in case you need any help!! 😁😁

CPerezz avatar Nov 22 '22 05:11 CPerezz

Hey!!! That's nice!! Ping in case you need any help!! 😁😁 I've finished. Please have a view if it's fix this issue. @CPerezz

SuccinctPaul avatar Nov 22 '22 06:11 SuccinctPaul

resolved in #963

ChihChengLiang avatar May 19 '23 08:05 ChihChengLiang