zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Port integration tests from zkevm-chains

Open ChihChengLiang opened this issue 2 years ago • 3 comments

Describe the feature you would like

We deprecated the zkevm-chain repo, but there are integration tests we would like to keep running them.

The tests include:

  • https://github.com/privacy-scaling-explorations/zkevm-chain/blob/master/coordinator/tests/worst_case.rs

Related issues

  • #1557

ChihChengLiang avatar Aug 03 '23 22:08 ChihChengLiang

#1550 only generates the contracts for the tests, but we haven't added the actual tests yet.

Some more PRs are required to complete this task.

ChihChengLiang avatar Aug 07 '23 08:08 ChihChengLiang

next step: create blocks for benchmarking : issue #1557

AronisAt79 avatar Aug 07 '23 13:08 AronisAt79

Note: Reevaluate where to remove or keep this https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/9e974d94e8491b482fc6293d4ab16b979cf346a2/zkevm-circuits/tests/prover_error.rs after the tests are ported. If it is not used in the test then we should remove it.

ChihChengLiang avatar Aug 15 '23 17:08 ChihChengLiang