zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Find lowest CircuitsParams values required for Default test runs

Open CPerezz opened this issue 2 years ago • 1 comments

We should try to get the minimum values needed so that all the tests pass with the Default CircuitsParams (unless the tests that instenciate the params themseleves).

https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/f185b1276b67b730448724930b33c72a342ad96a/bus-mapping/src/circuit_input_builder.rs#L68

CPerezz avatar Feb 14 '23 10:02 CPerezz

Probably this will be superseded by https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/954 which should bring dynamic calculation of CircuitsParams for each unit test (which means using the minimum params values for each unit test, leading to better performance of the MockProver in unit tests)

ed255 avatar May 31 '23 15:05 ed255