mpz icon indicating copy to clipboard operation
mpz copied to clipboard

Published 20 hours ago • verified publisher icon privacy-scaling-explorations

Run CI-tests with and without "simd-transpose"

Open heeckhau opened this issue 1 year ago • 3 comments

The CI tests currently only run with "simd-transpose" disabled. We should also run the build/test with "simd-transpose" enabled.

See also https://github.com/tlsnotary/mpz/pull/27#pullrequestreview-1527795809

heeckhau avatar Jul 18 '23 06:07 heeckhau

Add "force-soft" too, https://github.com/tlsnotary/mpz/blob/86f16874859a3369e878967fc2f4146411d74492/clmul/Cargo.toml#L21

heeckhau avatar Jul 18 '23 06:07 heeckhau

My understanding was that "enabling simd-transpose referred to the feature flag of the mpz crate matrix-transpose.

Don't we run all tests with --all-features so we already test the simd version of this library. The version without this feature flag is not tested, I guess.

th4s avatar Jul 18 '23 08:07 th4s

Don't we run all tests with --all-features so we already test the simd version of this library. The version without this feature flag is not tested, I guess.

I don't think so: we currently run:

cargo test --lib --bins --tests --examples --workspace

https://github.com/tlsnotary/mpz/blob/86f16874859a3369e878967fc2f4146411d74492/.github/workflows/rust.yml#L32C14-L32C68

heeckhau avatar Jul 18 '23 08:07 heeckhau