maci icon indicating copy to clipboard operation
maci copied to clipboard

Importing `maci-crypto` to a new project requires unnecessary GitHub auth

Open baumstern opened this issue 2 years ago • 0 comments

Problem

Importing maci-crypto to a new project would fails when there is no valid GitHub auth; GitHub requires auth when accessing repo using git://.

Example error

Addressed from https://github.com/privacy-scaling-explorations/maci/issues/470:

$ yarn add maci-crypto

error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/weijiekoh/circomlib.git
Directory: /Users/yuetloo/projects/clrfund/my-key
Output:
fatal: unable to connect to github.com:
github.com[0: 140.82.113.4]: errno=Operation timed out

Impact

This makes a frictions to import maci-crypto to a third party project, if they didn't set GitHub auth. We can't assume that GitHub auth has been configured on user-side.

Solution

using https instead of git in package.json of maci-crypto. https access to GitHub didn't require an auth

baumstern avatar Jul 20 '22 10:07 baumstern