halo2 icon indicating copy to clipboard operation
halo2 copied to clipboard

Add an assertion to prevent dynamic lookups without selectors/fixed

Open CPerezz opened this issue 1 year ago • 2 comments

This would prevent errors like PSE-ZKEVM dynamic lookups to happen unnoticed.

CPerezz avatar Nov 02 '23 10:11 CPerezz

Can you provide some explanation/ example of this error @CPerezz ? Thanks!

davidnevadoc avatar Nov 14 '23 10:11 davidnevadoc

Here is an example: the diff of the PR shows what changed, and there is a RAM example test. https://github.com/axiom-crypto/halo2-lib/pull/206

jonathanpwang avatar Nov 15 '23 04:11 jonathanpwang