oelint-adv icon indicating copy to clipboard operation
oelint-adv copied to clipboard

change test parameterization layout

Open HerrMuellerluedenscheid opened this issue 3 years ago • 2 comments

@priv-kweihmann I'd like to refactor the test parameterization which I find hard to read, which is e.g. because keys and values are on the same indentation level they take a lot of vertical space. What do you think about this more compact style? Also this avoids indentation of the provided strings. The tripple quoted strings would have to be left-aligned to not have the precending tabs.

HerrMuellerluedenscheid avatar Nov 07 '21 12:11 HerrMuellerluedenscheid

I get your pain with the current parametrization... unfortunately I hadn't had an idea how to write in a better way, whilst keeping the flexibility of just writing key value pairs (filename, content).

I'm open to ideas - your change so far does feel a bit like moving things right to left, while I more and more come to the conclusion that it may need a more fundamental restructuring.

Actually I would suggest to document a test style guide first and make that one enforceable. Otherwise this could turn into a neverending story

priv-kweihmann avatar Nov 07 '21 12:11 priv-kweihmann

After our todays call, I'll provide an example how the parameterisation might be further improvided by removing redundancy with a method that prepares test inputs or a dedicated fixture.

HerrMuellerluedenscheid avatar Nov 10 '21 15:11 HerrMuellerluedenscheid