slice-machine icon indicating copy to clipboard operation
slice-machine copied to clipboard

set default dns result to ipv4 (node17,18)

Open hypervillain opened this issue 1 year ago • 3 comments

Node dns resolution was refactored starting at node v17, using ipv6 by default. This prevented to node-fetch localhost on 2 OSX machines

hypervillain avatar Aug 10 '22 09:08 hypervillain

Are we still using node-fetch?

MarcMcIntosh avatar Aug 16 '22 09:08 MarcMcIntosh

Seems the only place where node-fetch / global fetch is used is in server//src/api/screenshots/puppeteer.ts:74: await fetch(screenshotUrl);

Would it make more sense to remove it and use axios?

MarcMcIntosh avatar Aug 16 '22 09:08 MarcMcIntosh

it does @MarcMcIntosh !

hypervillain avatar Aug 16 '22 16:08 hypervillain