slice-machine icon indicating copy to clipboard operation
slice-machine copied to clipboard

faker as a dependency

Open jasonmit opened this issue 3 years ago • 2 comments

Based on a quick grep of the codebase, faker is only used as a devDependency but is marked as a dependency which means consumers of slice-machine-ui end up installing faker as part of their yarn / npm install (which is a sizable project).

If it is used, would you be open to migrating to @faker-js/faker to avoid double installs for projects that have migrated over?

If my assumptions are correct, I'll send over a quick PR to address.

Thank you

jasonmit avatar Mar 08 '22 22:03 jasonmit

Hello thank you for reporting this,

We will make a complete checkup of the SM dependencies on the release 0.3.4 to 1) Avoid installing extra dependencies 2) remove some unused dependencies.

I will keep you update

Miniplop avatar Mar 16 '22 15:03 Miniplop

@Miniplop Yes fixing the deps vunerabilities asap will be welcome. The high one, at least.

image

webda2l avatar Apr 19 '22 10:04 webda2l

Hey @jasonmit thanks for reporting this issue 😄. This has been fixed in the latest Slice Machine versions so i'll close this issue. 🎉

Heyrows avatar Aug 25 '22 14:08 Heyrows