slice-machine icon indicating copy to clipboard operation
slice-machine copied to clipboard

feat: add `allowCaption` option to image fields

Open angeloashmore opened this issue 1 year ago • 2 comments

[!IMPORTANT] Do not merge this PR. It is a proof-of-concept.

Context

DT-2008

The Solution

  • Use an alpha version of @prismicio/types-internal that includes the allowCaption image field option.
  • Add the allowCaption form field to the image widget.
  • Adjust the edit dialog to render the checkbox in a reasonable location.

[!NOTE] Since this is a proof-of-concept PR and will not be merged, we can ignore the failing Playwright test.

Impact / Dependencies

This PR allows developers to configure image fields with a caption. The page builder needs to be updated to read this option.

Checklist before requesting a review

  • [ ] I hereby declare my code ready for review.
  • [ ] If it is a critical feature, I have added tests.
  • [ ] The CI is successful.
  • [ ] If there could backward compatibility issues, it has been discussed and planned.

[OPT] Preview

image

angeloashmore avatar Mar 20 '24 22:03 angeloashmore

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Mar 21, 2024 0:56am

vercel[bot] avatar Mar 20 '24 22:03 vercel[bot]

Closing since this was just a proof of concept.

angeloashmore avatar Apr 05 '24 23:04 angeloashmore