studio icon indicating copy to clipboard operation
studio copied to clipboard

Improve loading state for table + tree view

Open schickling opened this issue 6 years ago • 10 comments

https://www.loom.com/share/9d35fbd9ea3b45b9a7521d9faae3407b

schickling avatar Aug 23 '19 08:08 schickling

Should this be alleviated with triggering the requets for new rows sooner?

Here's few mockups for "placeholder rows" if we should need them though.

table-row-placeholders tree-row-placeholders

kuldar avatar Aug 27 '19 01:08 kuldar

Let's do both! 💯

schickling avatar Aug 28 '19 18:08 schickling

Will add in skeleton rows too, but with a few perf improvements in alpha.160, white spaces like the one you saw should become pretty rare!

sdnts avatar Sep 05 '19 11:09 sdnts

IMO let's also defer this until after we have a way to know exactly how many records exist in a table. I can then show the correct number of skeleton rows. Thoughts?

sdnts avatar Sep 05 '19 11:09 sdnts

IMO let's also defer this until after we have a way to know exactly how many records exist in a table. I can then show the correct number of skeleton rows. Thoughts?

I think there's no harm in filling the screen with skeleton rows even if there are less than displayed while loading. Agree @kuldar?

schickling avatar Sep 11 '19 09:09 schickling

Will add in skeleton rows too, but with a few perf improvements in alpha.160, white spaces like the one you saw should become pretty rare!

Would be great to implement this soon as it's still very common for the cases I've tried. (I guess related to the fix for #106.)

schickling avatar Sep 11 '19 15:09 schickling

@schickling @madebysid @kuldar is this being worked on? If not, any notion re: priority?

idan avatar Oct 01 '19 18:10 idan

tl;dr not sure if to schedule for beta or post-beta

idan avatar Oct 01 '19 18:10 idan

@idan It isn't, but since yesterday's discussion, I'm planning on picking this (and empty states) up soon. IMO pre-beta, since it isn't a whole lot of work anyway.

sdnts avatar Oct 02 '19 08:10 sdnts

We'll do this for the table view.

We'll do it for the tree view if it takes less than 1 hour, otherwise we'll tackle that post-Beta.

matthewmueller avatar Mar 02 '20 10:03 matthewmueller

Hey :wave:

Prisma ORM 7 introduces a brand new standalone Studio, built from the ground up to work everywhere, with or without Prisma ORM. Consequently, all "old Studio" issues are being closed as there won't be any further work on it. :mega:

The new Studio is also available in the Prisma VS Code extension and in the Prisma Console application. :electric_plug:

Help shape, improve and fix the new Studio with us in this repository by submitting bug reports and feature requests. :construction_worker:

igalklebanov avatar Nov 20 '25 01:11 igalklebanov