prisma-examples icon indicating copy to clipboard operation
prisma-examples copied to clipboard

feat: rest-express-auth example

Open gautvm opened this issue 3 years ago • 10 comments

This is the PR where I am working on the rest-express-auth example, details #2838. This is currently a draft.

gautvm avatar May 18 '21 17:05 gautvm

Hi @eternalmoon1234 👋🏽

Do you have any updates on this PR? Would you like any help pushing this across the finish line? 🙂

ruheni avatar Nov 22 '21 09:11 ruheni

Hey @eternalmoon1234 👋🏽

Do you intend to pick up this PR, and do you need any help?

ruheni avatar Mar 31 '22 15:03 ruheni

Hey @ruheni, ✋ Yes, I do intend to pick up the PR and will finish it by the end of next week! Sorry for the inactivity with this, I've been coding on and off recently and I must say I forgot about this 😅

Looking forward to finishing this!

gautvm avatar Jul 16 '22 06:07 gautvm

Hey @ruheni 👋

I finally finished up this PR. I've implemented the changes you proposed (as well as some others) and have followed the same standard of the rest-express-auth example.

Please review & propose any changes when you can!

gautvm avatar Mar 07 '23 22:03 gautvm

Hey @ruheni 👋

I've incorporated all of your requested changes. As for the protected routes, I've modified the ones that I thought required protection based on your guidance, although please feel free to suggest any alterations if you'd propose something different.

Please let me know if there's anything else you'd like me to change 🙂

gautvm avatar Mar 20 '23 22:03 gautvm

Do I need to update the rest test and postman collection now that there are protected routes?

gautvm avatar Mar 21 '23 17:03 gautvm

Hey 👋🏾 I would recommend creating a new test and collection for it to get the tests to pass.

ruheni avatar Mar 22 '23 07:03 ruheni

Sounds good, I'll go ahead and write the new test in.

gautvm avatar Apr 01 '23 18:04 gautvm

Hey @ruheni 👋

The tests should pass now. Mind running the checks & verifying that everything's all good? If so, I think this is ready to merge.

gautvm avatar May 16 '23 05:05 gautvm