prisma-engines icon indicating copy to clipboard operation
prisma-engines copied to clipboard

fix(schema): Tolerate internal CRDB enums

Open john-privy opened this issue 6 months ago • 6 comments

Addresses https://github.com/prisma/prisma/issues/11127.

This is a barebones fix without tests to get any feedback on approach first.

john-privy avatar Jul 11 '25 14:07 john-privy

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 11 '25 14:07 CLAassistant

CodSpeed Performance Report

Merging #5530 will not alter performance

Comparing john-privy:fix/tolerate-internal-crdb_enums (1b53140) with main (cf92c4b)

Summary

✅ 11 untouched benchmarks

codspeed-hq[bot] avatar Jul 15 '25 15:07 codspeed-hq[bot]

Hi @john-privy, this sounds like a sensible approach to me, thanks! Can you push test fixes too?

I recommend the following test setup commands:

  • cargo fix
  • cargo clippy --workspace --all-features
  • make dev-cockroach_23_1
  • export TEST_DATABASE_URL="postgresql://prisma@localhost:26260"
  • UPDATE_EXPECT=1 cargo test --package sql-introspection-tests -- --show-output --test-threads=1

jkomyno avatar Jul 25 '25 11:07 jkomyno

Hi @john-privy, this sounds like a sensible approach to me, thanks! Can you push test fixes too?

I recommend the following test setup commands:

Excellent and for sure!

One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?

john-privy avatar Jul 29 '25 16:07 john-privy

Hi @john-privy, this sounds like a sensible approach to me, thanks! Can you push test fixes too? I recommend the following test setup commands:

Excellent and for sure!

One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?

Friendly bump on this ask JIC, thanks!

john-privy avatar Aug 18 '25 13:08 john-privy

One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?

@john-privy We can def look into that. Should we take this up via email? If that's ok, pls shoot me a msg at gupta at prisma dot io.

gniting avatar Aug 18 '25 15:08 gniting