fix(schema): Tolerate internal CRDB enums
Addresses https://github.com/prisma/prisma/issues/11127.
This is a barebones fix without tests to get any feedback on approach first.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
CodSpeed Performance Report
Merging #5530 will not alter performance
Comparing john-privy:fix/tolerate-internal-crdb_enums (1b53140) with main (cf92c4b)
Summary
✅ 11 untouched benchmarks
Hi @john-privy, this sounds like a sensible approach to me, thanks! Can you push test fixes too?
I recommend the following test setup commands:
-
cargo fix -
cargo clippy --workspace --all-features -
make dev-cockroach_23_1 -
export TEST_DATABASE_URL="postgresql://prisma@localhost:26260" -
UPDATE_EXPECT=1 cargo test --package sql-introspection-tests -- --show-output --test-threads=1
Hi @john-privy, this sounds like a sensible approach to me, thanks! Can you push test fixes too?
I recommend the following test setup commands:
Excellent and for sure!
One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?
Hi @john-privy, this sounds like a sensible approach to me, thanks! Can you push test fixes too? I recommend the following test setup commands:
Excellent and for sure!
One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?
Friendly bump on this ask JIC, thanks!
One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?
@john-privy We can def look into that. Should we take this up via email? If that's ok, pls shoot me a msg at gupta at prisma dot io.