prisma-engines
prisma-engines copied to clipboard
[DA] Planetscale engine tests: occ
This is a subcluster of failures after having enabled planetscale tests in https://github.com/prisma/prisma-engines/pull/4423
Failing tests in this cluster:
new::occ::occ::occ_delete_test
new::occ::occ::occ_update_many_test
new::occ::occ::occ_update_test
Please follow this process
Is this potentially related to https://github.com/prisma/prisma/issues/21867?
I confirm that this is related to https://github.com/prisma/prisma/issues/21867.
If our PlanetScale drivers were set up to be using relationMode = "foreignKeys"
in the query-engine test suite, the OCC test cases above would pass with both the Vitess("planetscale.js")
(Napi) and the Vitess("planetscale.js.wasm")
(Wasm) test tags:
test new::occ::occ::occ_update_many_test ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 4.68s
test new::occ::occ::occ_delete_test ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 1.93s
test new::occ::occ::occ_update_test ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 1.84s
I'd recommend a refactoring of the connector-test-kit-rs
test suite setup to allow opting in and out of relationMode = "prisma" | "foreignKeys"
, so that we can consistently run CI on e.g. OCC tests with PlanetScale. The specifics of this technical change can be discussed with other engineers in the team.