prisma-engines icon indicating copy to clipboard operation
prisma-engines copied to clipboard

feat: add "denoDeploy" preview feature flag for client

Open kt3k opened this issue 3 years ago • 2 comments

This is a preliminary work for Deno Deploy support of prisma client. We're going to implement Deno Deploy specific feature under this feature flag. (Please see the prisma/deno shared channel for more context.)

kt3k avatar Aug 02 '22 08:08 kt3k

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 02 '22 08:08 CLAassistant

Note: related to https://github.com/prisma/prisma/pull/14386

Slack: https://prisma-company.slack.com/archives/C03MQBP84E6/p1659032973203539

Jolg42 avatar Aug 02 '22 08:08 Jolg42

I think this change is necessary for continuing the work at prisma/prisma#14386. PTAL @millsp @matthewmueller

kt3k avatar Aug 23 '22 09:08 kt3k

@garrensmith can you please create an integration version for @kt3k (if not already)?

millsp avatar Aug 29 '22 23:08 millsp

Is there anything I can do to help this get merged?

kt3k avatar Aug 31 '22 04:08 kt3k

Hey @kt3k we can't merge this as-is yet otherwise the preview feature would show up to our users (if we release). What we can do is to release an integration of this for you to work with in the client. Triggered here https://github.com/prisma/prisma-engines/pull/3161. I'll send you extra instructions when this is out.

millsp avatar Aug 31 '22 16:08 millsp

@millsp Thanks!

kt3k avatar Aug 31 '22 16:08 kt3k

Hey @kt3k here's the integration version. This is basically our main branch with the engines that you've modified in this PR. You can directly update the engines versions in your own TypeScript PR. Just run pnpm run bump-engines 4.4.0-4.integration-deno-preview-flag-3c1168fbf77b17ded4f89a480e467eddb5302d77 in the monorepo, and it will install the built engines of current PR.

millsp avatar Aug 31 '22 20:08 millsp

We decided to switch to using deno as the preview feature. I quickly recreated this PR as https://github.com/prisma/prisma-engines/pull/3291 and it was merged.

janpio avatar Oct 14 '22 21:10 janpio