Wasm module error behavior

[janpio]

Wasm module probably behaves different than binary, we should figure out how and make sure it is nice for users to understand and create issues based on it.

Related:

• https://github.com/prisma/language-tools/pull/966/files#r756836401
• https://github.com/prisma/language-tools/pull/966
• https://prisma-company.slack.com/archives/C02A1646TBR/p1637773282039600 + https://github.com/prisma/prisma-fmt-wasm/pull/8

[tomhoule]

This is what an unhandled engine prisma-fmt crash would like (a non-helpful JS exception). We have error handlers for most methods though, I'll check what would happen there now.

[tomhoule]

Here's the output with the panic inside of a try block with a catch calling the error handler. What I understand from this: our error handler swallows errors (it's the same we used for the binary).

[tomhoule]

I double checked and can confirm it's the behaviour I observe.

[Jolg42]

the panics will throw unhelpful JS exceptions, we'd need to handle them and say what failed and how to report it

[Jolg42]

So the current implementation is only showing error messages for validateTextDocument (which calls lint()) And is surfaced via the onError callback as a notification error. https://github.com/prisma/language-tools/blob/main/packages/language-server/src/server.ts#L166-L168

Now the question is, do we want to have this notification error for all the methods? 🤔

[jkomyno]

Note: it may be possible to solve this issue by investigating ideas from this internal thread.

[Jolg42]

Note that logging was improved in https://github.com/prisma/language-tools/pull/1474