engines-wrapper icon indicating copy to clipboard operation
engines-wrapper copied to clipboard

ci: remove publish auto commit

Open Jolg42 opened this issue 3 years ago • 3 comments

It's actually not needed and causes noise as a failure of the workflow when 2 publish happen "at the same time" https://github.com/prisma/engines-wrapper/runs/3748154135?check_suite_focus=true

Maybe we should set the version to 0.0.0 in git now

Jolg42 avatar Nov 05 '21 09:11 Jolg42

Hm, isn't this commit how we connect the engines hash to the Npm version it got published as? How would I figure out which code version a released version contains? (The commit contains both the actual code change, and the version increase and calculation)

janpio avatar Nov 05 '21 09:11 janpio

This commit is purely for git history which is not needed.

We could use tags here if we wanted to track the state of the codebase when a release happens, that could be cleaner.

Jolg42 avatar Nov 05 '21 10:11 Jolg42

Right now this commit is a record of the release, and the connection of the engine hash to the @prisma/engines version that is published to Npm. Let's investigate if that could also be provided by tags.

janpio avatar Nov 05 '21 12:11 janpio