ecosystem-tests icon indicating copy to clipboard operation
ecosystem-tests copied to clipboard

Check published package sizes

Open millsp opened this issue 3 years ago • 7 comments

Write a test that makes sure we don't ship more things than we should. (eg. 42MB engine in SDK)

See https://www.notion.so/prismaio/Check-package-sizes-786e81e4c9c04a3f8443dcd410491775

millsp avatar Jan 13 '22 14:01 millsp

Note that we have https://prisma.github.io/prisma/dev/bench/ and could potentially add some things in the CI job that creates this.

janpio avatar Jan 13 '22 14:01 janpio

I just noticed that this is a duplicate of https://github.com/prisma/prisma/issues/10356. I'll let you @Jolg42 close one of both, depending on which CI you think this issue should be tackled.

millsp avatar Jan 13 '22 17:01 millsp

FYI: It happened again https://unpkg.com/browse/@prisma/[email protected]/dist/get-generators/

millsp avatar Jan 14 '22 13:01 millsp

"It"?

janpio avatar Jan 14 '22 14:01 janpio

That we shipped more than we should have, look at that 42MB engine.

millsp avatar Jan 14 '22 14:01 millsp

Ahh, that is unexpected :D

Yeah, we should then indeed prioritize that. (And fix it as well)

janpio avatar Jan 14 '22 14:01 janpio

We recently had to fix @prisma/internals https://github.com/prisma/prisma/pull/16649

Jolg42 avatar Dec 07 '22 10:12 Jolg42