ecosystem-tests icon indicating copy to clipboard operation
ecosystem-tests copied to clipboard

Use yarn resolutions for redwood dependency override

Open millsp opened this issue 4 years ago • 1 comments

Internal https://prisma-company.slack.com/archives/CL0AJEVSA/p1625882635040500

millsp avatar Jul 10 '21 15:07 millsp

Should already be possible in the update script as we were using that before.

If we can avoid it, we should though as it doubles the complexity and was a source of endless problems in the past.

janpio avatar Jul 11 '21 09:07 janpio

Note: we currently use the override in https://github.com/prisma/ecosystem-tests/blob/dev/platforms-serverless-vercel/vercel-with-redwood/api/package.json#L9-L12 https://github.com/prisma/ecosystem-tests/blob/dev/platforms-serverless-vercel/vercel-with-redwood/package.json#L16-L19

And we have this script (https://github.com/prisma/ecosystem-tests/blob/dev/platforms-serverless-vercel/vercel-with-redwood/patch-package-json.js ) that seems to update the version with the version from https://github.com/prisma/ecosystem-tests/blob/dev/.github/prisma-version.txt

Jolg42 avatar Aug 23 '22 09:08 Jolg42

We now have an issue about check-for-update doesn't bump resolutions in package.json -> https://github.com/prisma/ecosystem-tests/issues/3041

Jolg42 avatar Aug 23 '22 09:08 Jolg42