docs icon indicating copy to clipboard operation
docs copied to clipboard

Update `pgbouncer` docs

Open biw opened this issue 1 year ago • 1 comments

Due to https://github.com/prisma/prisma/issues/21531, the currect docs are incorrect regarding setting up pgbouncer with prisma. This updates the docs to reflect the correct info.

biw avatar Oct 18 '24 01:10 biw

LGTM

JelteF avatar Oct 18 '24 06:10 JelteF

@jharrell is there an update on this in terms of getting it merged?

gniting avatar Nov 21 '24 07:11 gniting

Hey @biw 👋 ,

Thanks for raising the PR! I left some suggestions and we can merge this in after those are resolved.

ankur-arch avatar Dec 02 '24 15:12 ankur-arch

I imagine having docs for multiple versions/configurations of PgBouncer would add confusion for the vast majority of developers, but can edit it if you disagree.

That's a fair point. However, users using older versions of PgBouncer will run into a different confusion 😄 . To simplify, I think we can also add a note asking users to use the latest version of PgBouncer.

A bigger question for you and the dev team at prisma is: "Should ?pgbouncer=true be deprecated given that @JelteF, one of the maintainers of PgBouncer recommends not using it?"

That's a very good question @biw and has been brought to the attention of our team. I'll follow-up on our discussions here 👍 .

Sidenote: this PR will close https://github.com/prisma/docs/issues/5708.

ankur-arch avatar Dec 03 '24 09:12 ankur-arch

Thanks for your patience @biw and @JelteF ! Excited to get this merged 😊

jharrell avatar Dec 04 '24 17:12 jharrell