docs icon indicating copy to clipboard operation
docs copied to clipboard

fix(relations): Optional/mandatory headlines for 1-1 and 1-n

Open janpio opened this issue 2 years ago • 2 comments

janpio avatar Oct 07 '22 21:10 janpio

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 2:01pm

vercel[bot] avatar Oct 07 '22 21:10 vercel[bot]

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

github-actions[bot] avatar Oct 07 '22 21:10 github-actions[bot]

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

github-actions[bot] avatar Nov 15 '23 13:11 github-actions[bot]

Made some comments. TL;DR I think our terminology should be "nullable" and "non-nullable"

jharrell avatar Nov 16 '23 15:11 jharrell

What I used here is established terminology in Prisma context.

  • We always use "mandatory" in this context to describe them being "non optional".
  • "null" is not a concept that exists in Prisma context. There things are optional or not, which is then translated to nullable on the database level.

janpio avatar Nov 16 '23 19:11 janpio

What I used here is established terminology in Prisma context.

  • We always use "mandatory" in this context to describe them being "non optional".
  • "null" is not a concept that exists in Prisma context. There things are optional or not, which is then translated to nullable on the database level.

There doesn't seem to be any established terminology since we're using all of these terms across the docs.

For that reasons and because they're all interchangeable, I wouldn't let this discussion block the merging of this PR if it otherwise looks good.

The "real" solution here will be to determine one term (my vote would go to "required") that we want to use in this context and then update the docs everywhere to use that term consistently. I created an issue for that: https://github.com/prisma/docs/issues/5487

I would encourage to merge this PR regardless of the terms being use.

nikolasburk avatar Nov 23 '23 07:11 nikolasburk

Taking that as an approval and merging.

janpio avatar Nov 23 '23 10:11 janpio