docs
docs copied to clipboard
feat: Linkable search
Describe this PR
Changes
What issue does this fix?
Any other relevant information
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
docs | ✅ Ready (Inspect) | Visit Preview | Aug 16, 2022 at 11:11AM (UTC) |
Deploy Preview for prisma2-docs ready!
Name | Link |
---|---|
Latest commit | f6d8fbc8dda8f9737a1ae97136ae6bdbc80331a0 |
Latest deploy log | https://app.netlify.com/sites/prisma2-docs/deploys/62fb7ab8a4108200084b3f9f |
Deploy Preview | https://deploy-preview-3556--prisma2-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
This PR changes the following pages (Netlify/Vercel Preview Deploy links):
Changed Netlify links
Changed Vercel links
- This PR does not change any pages the GH Actions workflow could detect.
(Note that links will only be valid after Netlify/Vercel preview deploy succeeded)
@nilubava https://docs-git-linkable-search-prisma.vercel.app/?query=mongo&page=1 looks like this for me in Firefox / Chrome
It does open the search box and adds the keyword, but it doesn't load the results.
@Jolg42 Can you check now?
Does update URL, which is linkable: https://docs-git-linkable-search-prisma.vercel.app/?query=referential&page=1
Clicking into search box shows endless spinner though and seems to load things 🔴
Are pages like https://docs-git-linkable-search-prisma.vercel.app/?query=test&page=1 indexable by Google? They optimally should not be (even when discovering these should be hard for Google - but they are not for example linked here.)
@nilubava It does work and loads results on my browser (Firefox) after I cleared the cache, nice!
@janpio we could add these query parameters to the robots.txt file to ignore them like this
# duplicated so we can ignore them independently of their position in the url
Disallow: /*?query=*
Disallow: /*?page=*
Disallow: /*&query=*
Disallow: /*&page=*
@janpio "Clicking into search box shows endless spinner though and seems to load things 🔴" can you give me the steps to reproduce this?
- Open https://docs-git-linkable-search-prisma.vercel.app/
- Click into search box
- Observe endless spinner and visual impression it loading stuff over and over
Indeed, the search works when you enter a keyword.
But the endless spinner is unexpected when clicking on search, the input is empty and looks like this
@Jolg42 @janpio Can you confirm if this is good to go?
Looks good to me 👍🏼