docs icon indicating copy to clipboard operation
docs copied to clipboard

fix: update dependencies (MERGE AFTER MOVING TO VERCEL)

Open nilubava opened this issue 3 years ago • 7 comments

https://github.com/prisma/docs/issues/1790

nilubava avatar Jul 11 '22 16:07 nilubava

Deploy Preview for prisma2-docs ready!

Name Link
Latest commit 9c115e7e1263a48824d162a7b04fef0912ba3b78
Latest deploy log https://app.netlify.com/sites/prisma2-docs/deploys/62fb54602cd0c100074d708a
Deploy Preview https://deploy-preview-3407--prisma2-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 11 '22 16:07 netlify[bot]

This PR changes the following pages (Netlify/Vercel Preview Deploy links):

Changed Netlify links

Changed Vercel links

(Note that links will only be valid after Netlify/Vercel preview deploy succeeded)

github-actions[bot] avatar Jul 11 '22 16:07 github-actions[bot]

Hi @Nilu is this one ready for merging?

tanberry avatar Jul 13 '22 19:07 tanberry

The detected visual changes by Percy are a bit sus, but I guess that the new one renders things a bit different?

  • Ah, some code formatting changes quite drastically - but for the better.
  • Some line height or padding also has to have changed, but minimally and it only becomes drastic in Percy because it accumulates a lot over the long files we have.
  • So with all these changes super hard to say, but I think I agree with Nilu that the visual changes that Percy picked up are ok.

Not clear regarding interactive functionality of the docs though. No idea how to test that and how that could be influences as we do not really have any tests for that. Manually tested search, and that still seems to work as before.

janpio avatar Jul 13 '22 20:07 janpio

@janpio Yes, the percy changes looked ok to me :) and @tanberry Can you please confirm there is no unexpected changes in the UI - maybe just click around a bit and confirm all the pages look like before :)

nilubava avatar Jul 15 '22 08:07 nilubava

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ❌ Failed (Inspect) Aug 20, 2022 at 0:41AM (UTC)

vercel[bot] avatar Jul 15 '22 08:07 vercel[bot]

Deps not updated in this PR:

  • Percy related packages
  • @mdx-js/mdx, @mdx-js/react

nilubava avatar Jul 15 '22 08:07 nilubava

@janpio fixed, can you check if its good to go?

nilubava avatar Aug 16 '22 10:08 nilubava

Unfortunately does the CI job for Percy fail, so can not check if the layout is negatively impacted. It should not be for this to be approved and merged.

janpio avatar Aug 20 '22 00:08 janpio

This is a bit too polluted, so I tried a different approach to update deps. Closing this PR in favor of https://github.com/prisma/docs/pull/3778

nilubava avatar Sep 14 '22 13:09 nilubava