docs
docs copied to clipboard
fix: update dependencies (MERGE AFTER MOVING TO VERCEL)
https://github.com/prisma/docs/issues/1790
Deploy Preview for prisma2-docs ready!
| Name | Link |
|---|---|
| Latest commit | 9c115e7e1263a48824d162a7b04fef0912ba3b78 |
| Latest deploy log | https://app.netlify.com/sites/prisma2-docs/deploys/62fb54602cd0c100074d708a |
| Deploy Preview | https://deploy-preview-3407--prisma2-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
This PR changes the following pages (Netlify/Vercel Preview Deploy links):
Changed Netlify links
- /docs/concepts/components/prisma-schema/generators (currently)
- /docs/concepts/components/prisma-schema/data-model (currently)
- /docs/concepts/components/prisma-schema/indexes (currently)
- /docs/concepts/components/prisma-client/composite-types (currently)
- /docs/concepts/components/prisma-client/metrics (currently)
- /docs/concepts/components/prisma-studio (currently)
- /docs/concepts/more/comparisons/prisma-and-sequelize (currently)
- /docs/guides/database/developing-with-prisma-migrate/squashing-migrations (currently)
- /docs/guides/deployment/deployment-guides/deploying-to-cloudflare-workers (currently)
- /docs/guides/upgrade-guides/upgrading-versions/upgrading-to-prisma-4 (currently)
- /docs/reference/api-reference/prisma-schema-reference (currently)
- /docs/data-platform/data-proxy (currently)
- /docs/data-platform/data-browser (currently)
- /docs/data-platform/query-console (currently)
- /docs/data-platform/schema-viewer (currently)
- /docs/data-platform/members/user-roles (currently)
- /docs/data-platform/members (currently)
- /docs/data-platform/billing/manage-plans (currently)
- /docs/data-platform/troubleshooting/connection-to-db-timed-out (currently)
Changed Vercel links
- /docs/concepts/components/prisma-schema/generators (currently)
- /docs/concepts/components/prisma-schema/data-model (currently)
- /docs/concepts/components/prisma-schema/indexes (currently)
- /docs/concepts/components/prisma-client/composite-types (currently)
- /docs/concepts/components/prisma-client/metrics (currently)
- /docs/concepts/components/prisma-studio (currently)
- /docs/concepts/more/comparisons/prisma-and-sequelize (currently)
- /docs/guides/database/developing-with-prisma-migrate/squashing-migrations (currently)
- /docs/guides/deployment/deployment-guides/deploying-to-cloudflare-workers (currently)
- /docs/guides/upgrade-guides/upgrading-versions/upgrading-to-prisma-4 (currently)
- /docs/reference/api-reference/prisma-schema-reference (currently)
- /docs/data-platform/data-proxy (currently)
- /docs/data-platform/data-browser (currently)
- /docs/data-platform/query-console (currently)
- /docs/data-platform/schema-viewer (currently)
- /docs/data-platform/members/user-roles (currently)
- /docs/data-platform/members (currently)
- /docs/data-platform/billing/manage-plans (currently)
- /docs/data-platform/troubleshooting/connection-to-db-timed-out (currently)
(Note that links will only be valid after Netlify/Vercel preview deploy succeeded)
Hi @Nilu is this one ready for merging?
The detected visual changes by Percy are a bit sus, but I guess that the new one renders things a bit different?
- Ah, some code formatting changes quite drastically - but for the better.
- Some line height or padding also has to have changed, but minimally and it only becomes drastic in Percy because it accumulates a lot over the long files we have.
- So with all these changes super hard to say, but I think I agree with Nilu that the visual changes that Percy picked up are ok.
Not clear regarding interactive functionality of the docs though. No idea how to test that and how that could be influences as we do not really have any tests for that. Manually tested search, and that still seems to work as before.
@janpio Yes, the percy changes looked ok to me :) and @tanberry Can you please confirm there is no unexpected changes in the UI - maybe just click around a bit and confirm all the pages look like before :)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| docs | ❌ Failed (Inspect) | Aug 20, 2022 at 0:41AM (UTC) |
Deps not updated in this PR:
- Percy related packages
- @mdx-js/mdx, @mdx-js/react
@janpio fixed, can you check if its good to go?
Unfortunately does the CI job for Percy fail, so can not check if the layout is negatively impacted. It should not be for this to be approved and merged.
This is a bit too polluted, so I tried a different approach to update deps. Closing this PR in favor of https://github.com/prisma/docs/pull/3778