react-native-fullstack-graphql icon indicating copy to clipboard operation
react-native-fullstack-graphql copied to clipboard

Published 20 hours ago • verified publisher icon prisma-archive

[WIP] Add minimal boilerplate

Open chakrihacker opened this issue 7 years ago • 12 comments

chakrihacker avatar Apr 09 '18 19:04 chakrihacker

@chakrihacker Thanks for submitting this PR! We already have a PR open for a minimal boilerplate that is very similar to your PR, but had one main problem, the ApolloClient uri.

Here is the PR #72

And here is the blocking issue for which we haven't accepted many updates lately: #98

DevanB avatar Apr 09 '18 20:04 DevanB

Hi @DevanB thanks for pointing out existing PR. I am using expo constants to find dev url,so this makes sure even your emulator/simulator is in wifi/lan it connects to server.

chakrihacker avatar Apr 10 '18 04:04 chakrihacker

@chakrihacker - thanks for updating your PR. I’ll review within the next few days.

I might have a few more adjustments before accepting and merging. But if you’ll work through them, we will get your hard work merged in!

Thanks for submitting the PR!

DevanB avatar Apr 11 '18 01:04 DevanB

Sure No problem!!!

chakrihacker avatar Apr 11 '18 06:04 chakrihacker

@chakrihacker

I started looking over your PR this evening. Can you refactor your PR to align with the same folder structure we have for the basic example and the PR I have mentioned (this one)?

DevanB avatar Apr 16 '18 03:04 DevanB

Hey, I modified structure can you check??

chakrihacker avatar Apr 19 '18 17:04 chakrihacker

Hello any updates on this??

chakrihacker avatar May 01 '18 14:05 chakrihacker

Looks good to merge

alecperkey avatar May 07 '18 18:05 alecperkey

Thanks a lot for your contribution @chakrihacker! 💪 Great that you identified all those improvements in your review, @DevanB! Let's get this polished and merged 😊

marktani avatar May 07 '18 22:05 marktani

Totally agree! Let's get this merged in and we can move on to the advanced boilerplate, which will be awesome to release to other developers!

DevanB avatar May 07 '18 22:05 DevanB

Hey @DevanB I have updated code based on your reviews. can we merge this.

chakrihacker avatar May 20 '18 14:05 chakrihacker

Hi, Any updates on this??

chakrihacker avatar Jul 02 '18 11:07 chakrihacker