graphcool-templates icon indicating copy to clipboard operation
graphcool-templates copied to clipboard

Smaller auth0 package

Open prestontighe opened this issue 7 years ago • 3 comments

  • Remove isomorphic-fetch (not being used)

prestontighe avatar Nov 10 '17 20:11 prestontighe

I was under the impression isomorphic-fetch just attached itself to the window or global object, so that the fetch that's used later is defined.

timwis avatar Nov 15 '17 11:11 timwis

@timwis You are right, it is used indeed. It could have been node-fetch however, because it doesn't run in the browser anyways. I would also use import fetch from 'node-fetch' so it's clear that it is actually being used.

kbrandwijk avatar Nov 15 '17 11:11 kbrandwijk

Ah ok didn't know what it did. Creating a global variable from requiring a package seems like bad practice to me but o well. At least do import fetch from 'node-fetch' like you said @kbrandwijk .

prestontighe avatar Nov 15 '17 20:11 prestontighe