Dieter Werthmüller
Dieter Werthmüller
Yes, I'll try to get a test in.
I kept it as simple as possible. Passing in complex data to compare with would result in a complex valued misfit before this PR. Now we can assert that it...
@santisoler - from my point of view it is good to go.
Awesome, thanks @santisoler!
Your suggestion would work for my use case, yes. But I think the way I tried to fix it here is better (IMHO) / more general. Lets say you input...
OK. If you prefer that then I will adjust it accordingly then. > would imply it has a different behavior for numpy array Indeed, it would mean that. Numpy arrays...
> it’s best to use its `astype(type, casting='safe’, copy=False)` method That could work, not sure which one to prefer (the suggested method or astype), I guess we would have to...
I did some testing now, and I like your suggestion @jcapriot! What do you think of the current implementation?
(Why does Codecov check the coverage of the `tests/`-directory?)
Codecov complains that the three test lines are not themselves tested - so I can happily ignore that I assume?