GenshinOverlay
GenshinOverlay copied to clipboard
Substract time taking a screenshot took when measuring cooldown
Hello, first of all I saw this project is temporary paused. I encountered the problem, that the cooldown bar takes significantly longer to reach 100% than my skill takes to go off cooldown (venti's 6sec skill takes ~9-10 for the cooldown bar to reach 100%).
I cannot compile the project because I don't know how to import all those packages and didn't use C# a lot in general. This means I can't find the reason for this myself. My PC is barely enough to fluently play genshin, so one of the reasons for this bug is probably my pc.
I changed (https://github.com/Yochyo/GenshinOverlay/blob/main/Util/IMG.cs) line 32 and 68 here. This substracts the time it took to take the screenshot and calculate the cooldown from the cooldown. This should reduce the difference between 6sec and 9-10sec.
The debug option itself gives an indication of how long a capture takes to perform, this should be almost instantaneous though I haven't tested on underperforming machines. If the iteration time when doing a capture via debug is >100ms then yes this change may produce a more accurate result.
Though regardless, I'm not able to compile the change myself currently. In order to compile it, you just need VS2019, open the solution and then in the Solution Explorer under the project heading, right-click References and add the correct reference paths to the librarys provided in the release build.