Pierre Rioux
Pierre Rioux
### BUG-3 I can agree on the second license (`b-plain`) without even checking the checkbox.
### BUG-4 I can find no way for a user to review the licenses they have signed. There are no links back to read them again. If I try to...
### BUG-5 In fact, going to `http://localhost:3000/nh_show_license/SOMETHING` can result in all sort of weird things, including when the SOMETHING is a normal CBRAIN license or a prefixed `neurohub/SOMETHING`
### BUG-6 The url `http://localhost:3000/nh_show_license/neurohub/c-plain_info` show the license but with a button on the side that does nothing.
### BUG-8 In the controller code, there is no validation at all that the value `params[:license]` is a valid license identifier. This is close to introducing security bugs with arbitrary...
I will post more comments in the code now.
I want this documentation to be part of the codebase. I am not sure which file is more appropriate, but given we have a library for loading and accessing Boutiques...
Once the methods are all nicely created, we can modify the integration code to use these methods instead of trying to directly access the `custom` structure.
The new helper `group_select` does not behave properly. If a programmer invokes it in a page with an explicit list of groups passed in options, it is not supposed to...
I'm raising the priority of this a little now.