SWE-agent icon indicating copy to clipboard operation
SWE-agent copied to clipboard

Published 20 hours ago • verified publisher icon princeton-nlp

Fix path to `keys.cfg`

Open klieret opened this issue 10 months ago • 4 comments

Currently we mostly get the path as

os.path.join(os.getcwd(), "keys.cfg")

that's bad, because we'll never be able to run the software outside of its repository root.

We should factor this out into a get_config_path function and replace the logic.

klieret avatar Apr 11 '24 14:04 klieret

  • [ ] Catch error like in #115

klieret avatar Apr 12 '24 18:04 klieret

agree that, now I got a problem when follow the README setup steps, already setup GITHUB_TOKEN in keys.cfg, but when i run the command of Inference , it says 'Neither GITHUB_TOKEN nor GITHUB_JWT_TOKEN found: running as unauthenticated'

huangjingcai avatar Apr 15 '24 08:04 huangjingcai

@huangjingcai Strange, that shouldn't happen if it's in keys.cfg. Can you open a bug report for that so we can iterate?

klieret avatar Apr 15 '24 14:04 klieret

@klieret happy to do that, the bug report: https://github.com/princeton-nlp/SWE-agent/issues/233

huangjingcai avatar Apr 16 '24 02:04 huangjingcai