arbiter icon indicating copy to clipboard operation
arbiter copied to clipboard

enhancement(arbiter-core): allow for error bubble up `Environment::run`

Open Alexangelj opened this issue 1 year ago • 1 comments

https://github.com/primitivefinance/arbiter/blob/a321af174c2e7ef7520f3c3fcf05dc66bfe97831/arbiter-core/src/environment/mod.rs#L249

I triggered the above while loop to exit, with no message or information, by triggering the following code in middleware's send_transaction method: https://github.com/primitivefinance/arbiter/blob/a321af174c2e7ef7520f3c3fcf05dc66bfe97831/arbiter-core/src/middleware/mod.rs#L406

Expected behavior is to have these errors propagated. In my case the while loop ended silently.

Alexangelj avatar Nov 18 '23 06:11 Alexangelj

@ts0yu this is what I mean when I'm mentioning we should refactor the Environment::run

Autoparallel avatar Feb 29 '24 00:02 Autoparallel