Unable to bump geth dep

Open shaspitz opened this issue 1 year ago • 0 comments

Merging eigenlayer operator cli into our monorepo requires all other go modules to bump their geth dep from v1.13.14 to v1.14.7, due to our go.work. See https://github.com/primev/mev-commit/pull/268. After upgrading geth, a few tests unexpectedly fail in the p2p and oracle modules.

In the meantime I'm going to continue development of the new go module in a separate repo, as the issue may be related to https://github.com/ethereum/go-ethereum/commit/ab49f228ad6f37ba78be66b34aa5fee740245f57 which mentions backwards incompatibility.

https://bazel.build/ might be a good solution to this issue for isolating deps between modules

TestKeyExchange_SendAndHandleTimestampMessage

TestKeyExchange_SendAndHandleTimestampMessage fails here with

--- FAIL: TestKeyExchange_SendAndHandleTimestampMessage (0.00s)
    keyexchange_test.go:121: SendTimestampMessage failed: error encrypting key for provider 0x6F689c2e11E67D212F20Da79911cfF97DDB99c0b: ecies: invalid elliptic curve

updater_test.go

https://github.com/primev/mev-commit/blob/985b84f76a3c0287487045d99b4d75493414a521/oracle/pkg/updater/updater_test.go fails in this manner

--- FAIL: TestUpdaterRevertedTxnsWithRevertingHashes (0.13s)
    updater_test.go:844: wrong isSlash
--- FAIL: TestUpdaterIgnoreCommitments (0.14s)
    updater_test.go:1245: wrong isSlash
--- FAIL: TestUpdater (0.03s)
    updater_test.go:303: wrong isSlash
FAIL

Jul 23 '24 20:07 shaspitz