view_components icon indicating copy to clipboard operation
view_components copied to clipboard

Tooltip visual refresh

Open langermank opened this issue 1 year ago • 3 comments

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans. Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Match the updated design we're drafting in Primer React. Check out the design docs for more details.

  • Fixes the color tokens to use v8 with fallback
  • Removes the caret
  • Adjusts offset
  • Removes animation delay

Integration

Bump PCSS

Risk Assessment

  • [x ] Low risk the change is small, highly observable, and easily rolled back.
  • [ ] Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • [ ] High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Lookbook)
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

langermank avatar Feb 13 '24 00:02 langermank

🦋 Changeset detected

Latest commit: 921a5f22c2d967b4832afbcab0b84f2f1f5c82c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 13 '24 00:02 changeset-bot[bot]

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

github-actions[bot] avatar Feb 13 '24 00:02 github-actions[bot]

⚠️ Hold off on merging to coordinate release with Primer React ⚠️

langermank avatar Feb 14 '24 16:02 langermank