view_components icon indicating copy to clipboard operation
view_components copied to clipboard

ActionMenu does not work inside Dialog

Open jalafel opened this issue 1 year ago • 2 comments

Hi Rails team! I'm trying to render an ActionMenu within a Dialog and I'm coming up against an error. This PR had fixed a different bug when ActionMenus were used to open a Dialog, but introduced a new one as the ActionMenu doesn't propagate any events inside a Dialog component, so is not functional.

Here's a video I setup in my local development:

https://github.com/primer/view_components/assets/12400507/c7fc20c5-4627-4f17-88b6-313e62ab2132

jalafel avatar Sep 29 '23 20:09 jalafel

@keithamus would you mind taking a look at this and letting me know what size you would assign the work (GitHub staff only), given your familiarity with these components? This will help us make the call on when to prioritize it.

lesliecdubs avatar Oct 04 '23 18:10 lesliecdubs

Pebble size. I'll look closely tomorrow and if I can, I'll raise a fix.

keithamus avatar Oct 04 '23 21:10 keithamus

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Apr 03 '24 00:04 github-actions[bot]