view_components icon indicating copy to clipboard operation
view_components copied to clipboard

Nested dialogs are dismissed immediately

Open koddsson opened this issue 3 years ago • 2 comments

The global click handler for dialogs doesn't differentiate what dialog is "at the top", so any click on the top dialog dismisses any dialog "below" if that click is outside that dialogs area.

A concrete example is a Dialog with position: :right, which includes a nested Dialog with default settings. Any clicks to the nested dialog will register as "outside" of the root dialog and close it.

koddsson avatar Sep 13 '22 09:09 koddsson

Thanks for opening this up, @koddsson!

I'm curious about the use case for nested dialogs, and whether that's a design pattern we want to support. @langermank I know you worked on defining the Dialog interface guidelines; do you have any thoughts on this?

lesliecdubs avatar Sep 14 '22 04:09 lesliecdubs

@lesliecdubs; Sure! I think nested dialogs are a bit 😬 but I was given a design for github/github which uses a side panel which includes a trigger for a more conventional dialog. I don't wanna give too much away in public since this is a unreleased feature but I can share additional info with you or the team in Slack.

koddsson avatar Sep 15 '22 11:09 koddsson