react

react copied to clipboard

Fix types of useAnchoredPosition to avoid type assertions.

1

Closes #4447 ### Changelog #### New #### Changed `useAnchoredPosition` types updated to remove user type assertions #### Removed ### Rollout strategy - [ ] Patch release - [ ] Minor...

T-Hugs

### Description The useAnchoredPosition hook will create refs if they are not passed in. However, when it does so, it creates a generic `React.RefObject` ref and returns that. Therefore, when...

T-Hugs

Update Tooltip v2 to use CSS Modules 💖

1

- Subset of https://github.com/github/primer/issues/3154 I'm creating this issue for tracking purposes. We plan to update the Tooltip v2 (draft) to use CSS modules and here are CSS variable suggestions @langermank...

broccolinisoup

The theme object inflates bundle size.

1

### Description `theme` object gets total 9 `colorSchemes`. And importing these color schemes under the `themes` object does not allow tree shaking. I bundled only theme object:  Only theme...

cihad

Allow non-memoized item lists

13

Closes https://github.com/primer/react/issues/4315 CC @ajhenry ### Changelog Fixes a bug in the `SelectPanel` component which required the same object to be stored in the `items` and `selectedItems` lists. #### New N/A...

ipc103

experimental/SelectPanel: Update anchored position after showModal

3

### The problem: When an html `` is not "open", it has the dimensions of 0px by 0px, which means the anchored position is not able to calculate if the...

siddharthkp

Type checking is too slow

3

On my machine type checking takes at least 18s to execute. This is an extremely long time to wait for feedback and contributes to poor DX. Even with watch mode...

keithamus

Dialog: Focus shifts unexpectedly on opening

8

### Description I've made a [Dialog](https://primer.style/components/dialog) that has 4 items you can choose from (ActionList items). When I open the dialog, it automatically highlights the last item you can choose....

maximedegreve

PageLayout doesn't extend the sidebar divider when extending the height.

5

### Description On GitHub, I've seen some pages using the PageLayout component, but there's a problem: when you can't scroll, the PageLayout doesn't stretch to fill the whole page, which...

maximedegreve

UnderlineNav items collapses into the more menu then it is wrapped with a flex

8

### Description When UnderlineNav is placed into a flex container, even though there are enough space, items are collapsed into the menu. I suspect that is happening due to the...

broccolinisoup