Remove the deprecated `SelectPanel` experimental component
Closes https://github.com/github/primer/issues/5440
This pull request removes the deprecated SelectPanel2 component and all related files, stories, styles, and documentation from the codebase. It also updates references to its mock data in other story files and cleans up exports that previously included SelectPanel2 types and components.
Changelog
New
Changed/Removed
Component removal and cleanup:
- Deleted the entire
SelectPanel2component and its documentation file (SelectPanel.docs.json), removing all code, props, and subcomponent definitions. - Removed all story files and story-specific CSS for
SelectPanel2, includingSelectPanel.stories.tsx,SelectPanel.playground.stories.tsx,SelectPanel.features.stories.module.css, andSelectPanel.module.css.
Exports and usage cleanup:
- Removed
SelectPaneland its related types from the exports snapshot to ensure they are no longer part of the public API. - Removed import of
mockDatafromSelectPanel2inActionBar.examples.stories.tsxand replaced its usage with a hardcoded value to eliminate dependency on the deleted component.
Rollout strategy
- [ ] Patch release
- [ ] Minor release
- [X] Major release; if selected, include a written rollout or migration plan
- [ ] None; if selected, include a brief description as to why
Testing & Reviewing
Merge checklist
- [X] Added/updated tests
- [X] Added/updated documentation
- [X] Added/updated previews (Storybook)
- [X] Changes are SSR compatible
- [X] Tested in Chrome
- [ ] Tested in Firefox
- [ ] Tested in Safari
- [ ] Tested in Edge
- [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)
🦋 Changeset detected
Latest commit: e4fc7bc464127425248d10cbd642664eb8a74c2d
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| @primer/react | Major |
| @primer/mcp | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
:wave: Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!
size-limit report 📦
| Path | Size |
|---|---|
| packages/react/dist/browser.esm.js | 87.97 KB (0%) |
| packages/react/dist/browser.umd.js | 88.08 KB (0%) |
:wave: Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!
👋🏻 @hectahertz is this PR still on your radar to get to merge? I'm noticing an unanswered review question and a growing number of conflicts 👀
@francinelucca This is still pending on the migration from the feature teams (PRs, copilot)
https://primer-query.githubapp.com/?query=name%3A%22SelectPanel%22+entrypoint%3A%22%40primer%2Freact%2Fexperimental%22
I just updated the PR but it will fail again eventually.
At this time there's stiill 3 usages; we should decide now if we want to move it to dotcom instead or spend some resources on helping them finally migrate away.
Note that this won't get released until our next major release anyway.
cc @hellojanehere @lesliecdubs