react icon indicating copy to clipboard operation
react copied to clipboard

Add gap between ActionList label and `trailingVisual`

Open langermank opened this issue 7 months ago • 3 comments

This should merge after the FF removal PR merges: https://github.com/primer/react/pull/6090

Closes https://github.com/primer/react/issues/6154

Changelog

New

Changed

Removed

Rollout strategy

  • [ ] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

langermank avatar Jun 06 '25 23:06 langermank

🦋 Changeset detected

Latest commit: 746fb33081e7562304eb948f67ee41b662781071

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 06 '25 23:06 changeset-bot[bot]

:wave: Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions[bot] avatar Jun 06 '25 23:06 github-actions[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.48 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js 92.7 KB (+0.16% 🔺)

github-actions[bot] avatar Jun 06 '25 23:06 github-actions[bot]

Would it be easy to add a screenshot/e2e test to capture this behavior or not really? 👀

joshblack avatar Jun 30 '25 16:06 joshblack

@joshblack great call, I'm doing a few other bugs for AL this week and I'll add this into a followup PR!

langermank avatar Jun 30 '25 18:06 langermank