react icon indicating copy to clipboard operation
react copied to clipboard

`ActionList.TrailingVisual` has insufficient left padding

Open iansan5653 opened this issue 7 months ago • 2 comments

ActionList.TrailingVisual lacks padding on the left/inline-start side. This isn't noticeable most of the time, because the text is either short enough that it doesn't matter, or wraps to create space. But in dynamically sized lists without wrapping, it can be very obvious and look broken. For example, notice that the trailing LinkExternalIcon here is practically touching the text:

an actionlist with a trailing visual icon that has insufficient space between the icon and text

iansan5653 avatar Jun 02 '25 16:06 iansan5653

Hi, thanks for filing this issue! I'm going to send this to the Primer First Responder to assess this request so we can get back to you.

Primer First Responder, please spend a minute scoping this request and:

  1. update the issue with a size: label
  2. add a comment with a time estimate for resolution
  3. add this issue back to the "Inbox" of the Primer teams backlog for further assessment and response

sunnyi101 avatar Jun 02 '25 16:06 sunnyi101

Just wanted to share that I was able to reproduce this with a very minimal example:

<ActionList style={{width: 'max-content'}}>
  <ActionList.Item>
    Item one
    <ActionList.TrailingVisual>
      <PencilIcon />
    </ActionList.TrailingVisual>
  </ActionList.Item>
</ActionList>

Which results in a pencil icon that is touching the text:

action list with text "Item one" and pencil icon on the right that is touching the text

iansan5653 avatar Jun 02 '25 16:06 iansan5653