react icon indicating copy to clipboard operation
react copied to clipboard

extend divider to parent by setting props by default on the root container (BoxWithFallback) in the PageLayout component

Open dwsosa opened this issue 8 months ago • 3 comments

Closes #4351

The PageLayout component is not opinionated about layout. By adjusting the props, it will fill its parent, and the divider will extend as expected:

BEFORE

before making the change

AFTER divider now extends to the height of the parent

Changelog

New

Changed

Removed

Rollout strategy

  • [ ] Patch release
  • [X] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [X] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

dwsosa avatar Apr 24 '25 18:04 dwsosa

🦋 Changeset detected

Latest commit: 5cc8f5f6da3555b9263c1e8e0596a0a582d78efc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Minor
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 24 '25 18:04 changeset-bot[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Sep 08 '25 22:09 github-actions[bot]

Re-requesting @jonrohan's review to see about getting workflows passing so we can merge this

lesliecdubs avatar Nov 18 '25 16:11 lesliecdubs