ButtonGroup WIP
Closes #
Changelog
New
Changed
Removed
Rollout strategy
- [ ] Patch release
- [ ] Minor release
- [ ] Major release; if selected, include a written rollout or migration plan
- [ ] None; if selected, include a brief description as to why
Testing & Reviewing
Merge checklist
- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Storybook)
- [ ] Changes are SSR compatible
- [ ] Tested in Chrome
- [ ] Tested in Firefox
- [ ] Tested in Safari
- [ ] Tested in Edge
- [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)
🦋 Changeset detected
Latest commit: d30f6fba67958e6315d2dfd2b0575e2caab09d25
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @primer/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
:wave: Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!
size-limit report 📦
| Path | Size |
|---|---|
| packages/react/dist/browser.esm.js | 103.18 KB (-0.06% 🔽) |
| packages/react/dist/browser.umd.js | 103.6 KB (+0.08% 🔺) |
👋🏻 Friendly bump on this as it looks to be getting stale. @langermank is this something you plan to move toward merge? Looks like it would resolve one of the outstanding Accessibility Automation action items on our scorecard: https://github.com/github/primer/issues/3726#issuecomment-2512483082
:wave: Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!
:wave: Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!
:wave: Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!
@iansan5653 I attempted to do that here https://github.com/primer/react/pull/5343 and that caused these bugs I think cause it's not always all button or all a
Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check https://github.com/primer/react/pull/5123#issuecomment-2547226908.
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.
Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.
:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355518
🟢 golden-jobs completed with status success.