react icon indicating copy to clipboard operation
react copied to clipboard

Update `PageLayout` condensed spacing to be 8px

Open langermank opened this issue 1 year ago • 4 comments

This seems like a bug that condensed and normal spacing values were almost identical. This PR updates the PageLayout component to use 8px for the condensed spacing instead of 16px, ensuring a clearer distinction between the two spacing options

Rollout strategy

I will be manually updating any instance of condensed to normal in dotcom

  • [ ] Patch release
  • [x] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

langermank avatar Sep 17 '24 15:09 langermank

🦋 Changeset detected

Latest commit: 1ea1c84172e6e8e6fa07ea2278584944f7905a8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 17 '24 15:09 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.59 KB (-0.1% 🔽)
packages/react/dist/browser.umd.js 97.84 KB (+0.04% 🔺)

github-actions[bot] avatar Sep 17 '24 15:09 github-actions[bot]

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344435

primer-integration[bot] avatar Sep 27 '24 19:09 primer-integration[bot]

:wave: Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions[bot] avatar Oct 14 '24 15:10 github-actions[bot]

Closing as this is just too big of a visual change. Will re-evaluate in the future.

langermank avatar Nov 05 '24 18:11 langermank